8000 Implemented history page night selection for deletion by MouradLachhab · Pull Request #62 · PolyCortex/polydodo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implemented history page night selection for deletion #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 12, 2020
Merged

Implemented history page night selection for deletion #62

merged 9 commits into from
Nov 12, 2020

Conversation

MouradLachhab
Copy link
Contributor

It is now possible to select night for deletion.

image

image

WilliamHarvey97
WilliamHarvey97 requested changes Nov 6, 2020
View reviewed changes
WilliamHarvey97
WilliamHarvey97 reviewed Nov 6, 2020
View reviewed changes
abelfodil
abelfodil requested changes Nov 9, 2020
View reviewed changes
abelfodil
abelfodil requested changes Nov 10, 2020
View reviewed changes
Copy link
Contributor
@abelfodil abelfodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peux-tu lancer un format pls?

@MouradLachhab
Copy link
Contributor Author

Peux-tu lancer un format pls?

Running flutter format **/*.dart did no changes except add one newline on one file. What changes were you looking for ? Maybe there are some linting settings that I don't have set.

@mateobelanger
Copy link
Contributor

Quand on visionne une nuit en particulier faudrait que le bouton du drawer devienne un bouton (flèche) pour retourner à la liste des nuits. C'est pas super important, mais niveau ergonomie de devoir rouvrir le drawer et retourner dans History c'est pas top.

WilliamHarvey97
WilliamHarvey97 reviewed Nov 12, 2020
View reviewed changes
mobile/lib/src/infrastructure/sleep_history/sleep_history_repository.dart

@override
void initializeRepository() {
SleepHistoryRepository() {
_sleepHistoryPersistency.add(mock_data_1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si le Repository est mock je propose qu'on le renomme MockSleepHistoryRepository. Lorsqu'on voudra implémenter la vrai version, on aura juste à créer une nouvelle classe SleepHistoryRepository et l'injecter dans l'app à la place de MockSleepRepository.

mobile/lib/src/application/sleep_sequence_history/sleep_sequence_history_cubit.dart
}

emit(SleepSequenceHistoryEditInProgress(
_sleepHistoryRepository.getSleepSequences(), _selectedSequences));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'imagine que ce sera async. Il faudrait probablement utiliser Future ISleepHistoryRepository::getSleepSequences(); J'imagine que les ajouts et suppression de la persistence retourneront aussi un Future.

@MouradLachhab MouradLachhab merged commit bf5d577 into master Nov 12, 2020
@MouradLachhab MouradLachhab deleted the history branch November 12, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateobelanger mateobelanger mateobelanger left review comments

@abelfodil abelfodil abelfodil approved these changes

@WilliamHarvey97 WilliamHarvey97 WilliamHarvey97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MouradLachhab @mateobelanger @abelfodil @WilliamHarvey97
0