8000 Smaller and faster to compile webapp builds by abelfodil · Pull Request #61 · PolyCortex/polydodo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Smaller and faster to compile webapp builds #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2020
Merged

Smaller and faster to compile webapp builds #61

merged 6 commits into from
Nov 4, 2020

Conversation

abelfodil
Copy link
Contributor
@abelfodil abelfodil commented Nov 4, 2020 •
edited
Loading

Observations:

  • reactstrap needs bootstrap css
  • we only use css (scss) from argon theme
  • once compiled, the argon css also includes bootstrap
  • .map files are useless for production

Conclusions:

  • We can remove the argon package and only put the .css instead
  • We can remove the bootstrap dependency as it's already included in the precompiled argon .css
  • We can disable .map file generation for production

@abelfodil abelfodil merged commit da4801b into master Nov 4, 2020
@abelfodil abelfodil deleted the lean branch November 4, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamHarvey97 WilliamHarvey97 WilliamHarvey97 approved these changes

@mateobelanger mateobelanger Awaiting requested review from mateobelanger

@conorato conorato Awaiting requested review from conorato

@MouradLachhab MouradLachhab Awaiting requested review from MouradLachhab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abelfodil @WilliamHarvey97
0