[Taxon sheet] Finalization of the taxon sheet #3479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3479 +/- ##
===========================================
+ Coverage 84.22% 84.25% +0.03%
===========================================
Files 132 132
Lines 10108 10306 +198
===========================================
+ Hits 8513 8683 +170
- Misses 1595 1623 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 25, 2025
45a470a to
40215ea
Compare
jacquesfize
reviewed
Apr 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un premier retour. Seul hic : la synthèse géographique ne fonctionne pas avec certaines espèces car il manquait un paramètre.
.../app/syntheseModule/taxon-sheet/tab-geographic-overview/tab-geographic-overview.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/GN2CommonModule/form/synthese-form/synthese-data.service.ts
Outdated
Show resolved
Hide resolved
.../app/syntheseModule/taxon-sheet/tab-geographic-overview/tab-geographic-overview.component.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacques Fize <4259846+jacquesfize@users.noreply.github.com>
edelclaux
commented
May 13, 2025
frontend/src/app/syntheseModule/taxon-sheet/tab-observations/tab-observations.component.ts
Outdated
Show resolved
Hide resolved
…w limited number of obs (as in the synthese)
b0afd29 to
4cc406e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette version de la fiche espèce, on retrouve différentes améliorations. Elles ont été rassemblées en une seule PR.
On retrouve ici:
Hésitez pas à me contacter si vous voulez une intro avant de faire la review !