8000 Import Monitoring by jacquesfize · Pull Request #3279 · PnX-SI/GeoNature · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Import Monitoring #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: develop
Choose a base branch
from
Draft

Import Monitoring #3279

wants to merge 32 commits into from

Conversation

jacquesfize
Copy link
Contributor
@jacquesfize jacquesfize commented Dec 9, 2024

This PR aggregates changes to GeoNature for the integration of the monitoring destination in the import module.

Copy link
codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 30 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (1848279) to head (97cffb2).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...nd/geonature/core/imports/checks/dataframe/cast.py 41.17% 20 Missing ⚠️
backend/geonature/core/imports/utils.py 86.04% 6 Missing ⚠️
backend/geonature/core/imports/actions.py 96.42% 1 Missing ⚠️
...nd/geonature/core/imports/checks/dataframe/core.py 97.05% 1 Missing ⚠️
backend/geonature/core/imports/routes/imports.py 96.15% 1 Missing ⚠️
...occhab/backend/gn_module_occhab/imports/actions.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3279      +/-   ##
===========================================
+ Coverage    84.24%   84.25%   +0.01%     
===========================================
  Files          131      131              
  Lines        10072    10146      +74     
===========================================
+ Hits          8485     8549      +64     
- Misses        1587     1597      +10     
Flag Coverage Δ
pytest 84.25% <87.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacquesfize jacquesfize force-pushed the feat/import-monitorings branch from 2b5f26f to dcc764e Compare January 3, 2025 12:39
@Pierre-Narcisi Pierre-Narcisi force-pushed the feat/import-monitorings branch from 719b85f to bfcf4a7 Compare January 20, 2025 16:12
@jacquesfize jacquesfize force-pushed the feat/import-monitorings branch 2 times, most recently from 84786fc to c987a38 Compare March 5, 2025 15:54
jacquesfize and others added 25 commits March 14, 2025 14:24
* feat(import): can post fieldmapping in new structured format
* fix(import): insert_import_data_in_transient_table
* fix(import): get_import_values
* fix(import): prepare_import
* feat(import): support default values
* feat(import): default value edition support nomenclature widget
 refactor(import): minor refact on getFieldMappingValues()
* feat(import): improve default value json edition
* feat(import): present default values on report
* feat(import): db migration
* feat(import): test default value
* test(import): support fieldmapping format v2
* feat(import): dynamic form on default values
* fix(import): no longer send empty string for date default value
* fix(import): test field jsonschema_definitions
* feat(import): fix occhab revisions
* feat(import): rename obsolete revision
* style(import): code format
* feat(import): fieldmapping validators deal with default values
* feat(import): occhab revision to set bib_fields.type_field
* Fix (migration) move migration to geonature branch

---------

Co-authored-by: Pierre-Narcisi <pierre.narcisi@epitech.eu>
…ing model (#3275)

* add id_import in monitoring model
* feat: add id_import columns in monitoring tables
* fix(db): change head of revision to latest in feat/import-monitorings

---------

Co-authored-by: Julien Corny <julien_corny@natural-soltuions.eu>
Co-authored-by: jacquesfize <jacques.fize@ecrins-parcnational.fr>
* feat: improve route resolver to import/:destinations with non existing destination
* feat: add frontend test to route resolver ipdate
* feat: add modal for edit import action

- create modal action component
- call modal on edit import and next button step
- add model modalData
- remove deleteModal (replace by new component)

[Refs]: https://github.com/orgs/PnX-SI/projects/13?pane=issue&itemId=82942301

Reviewed-by: andriacap

* refact: add logic to check if import is done

- Add method and accessor get to check if import is completed
- Replace code where checking if import is completed

Reviewed-by: andriacap

* fix: adjust to dataset displacement

* feat: add modal c onfirmation on frontend tests

* lint: frontend tests

* Apply suggestions from code review

---------

Co-authored-by: Etienne Delclaux <etienne_delclaux@natural-solutions.eu>
Co-authored-by: Jacques Fize <4259846+jacquesfize@users.noreply.github.com>
---------

Co-authored-by: Pierre-Narcisi <pierre.narcisi@epitech.eu>
Co-authored-by: Etienne Delclaux <etienne_delclaux@natural-solutions.eu>
@jacquesfize jacquesfize force-pushed the feat/import-monitorings branch from c987a38 to 54ac169 Compare March 14, 2025 13:41
jacquesfize and others added 4 commits March 25, 2025 10:30
* link an entity to an object code

* remove insecure on delete cascade

* wip
* feat: modifications of fielammping: static, clean, dynalmic form wrapper

* feat: default_value to constant

* feat: test constant switch button

* ui: edit constant button

* feat: update fieldmapping step formulary

* feat: improve field missing message

* fix: add migration to update constant boolean from column_src

* fix:adjust tests

* fix: adapt test to new xor behaviuor on 'column_src' vs 'constant_value'

* fix: frontend tests

* fix:  generate altitude in occhab

* fix: attempt at fixing test frontend

* test: force reload fieldmapping-input

* fix: update actions coverage

* update test cleaing

* test ci

* fix: date input in test

* feat: remove nom_cite

* minor fixes

---------

Co-authored-by: jacquesfize <jacques.fize@ecrins-parcnational.fr>
---------

Co-authored-by: Vincent Bourgeois <vincent_bourgeois@natural-solutions.eu>
Co-authored-by: jacquesfize <jacques.fize@ecrins-parcnational.fr>
* feat-import: make import compatible with single entity import

fix: ci maybe

fix: ci maybe

* fix: remove common string algorithm fixed

* fix: import also uuids (mandatory or generated)

* fix: setparentline_no : remove extra parent

* fix: child_entity --> entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0