8000 Changes to working tree not shown for non-English locales · Issue #13 · Piturnah/gex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Changes to working tree not shown for non-English locales #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 2 tasks
Piturnah opened this issue Dec 6, 2022 · 0 comments
Open
1 of 2 tasks

Changes to working tree not shown for non-English locales #13

Piturnah opened this issue Dec 6, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Piturnah
Copy link
Owner
Piturnah commented Dec 6, 2022 •
edited
Loading

In general Gex may run into issues when the locale is not English as it often directly parses the output from git.

In particular changes to the working tree are not shown as we are looking for the lines "Untracked files:" and "Changes not staged for commit:"

gex/src/status.rs

Line 317 in 71d455f

if line == "Untracked files:" {

gex/src/status.rs

Line 349 in 71d455f

} else if line == "Changes not staged for commit:" {

This is a pretty hacky solution and I would rather directly interface with libgit2.

I don't have the time to work on this right now so I am marking as "help wanted" and in the next release I will include a warning if the locale is not English. As stated in the README Gex is primarily a personal project, but that being said I do very much want to support non-English locales.

TODO:

  • Implement warning when locale is non-English
  • Actually fix the issue

Originally discovered in #7
@Piturnah Piturnah added bug Something isn't working help wanted Extra attention is needed labels Dec 6, 2022
Piturnah added a commit that referenced this issue Dec 6, 2022
@Piturnah
Add non-English locale warning (#13)
956d509
@Piturnah Piturnah pinned this issue Dec 8, 2022
@vereym vereym mentioned this issue Jun 27, 2023
Merged
Piturnah pushed a commit that referenced this issue Jun 27, 2023
@vereym
disallow diff.external to fix diff preview (#28)
6eff005 
Hey really enjoy using gex, but I noticed that since I started using an
external diff tool, gex would just show the whole file in the status
view, instead of the lines that changed.

Since I am okay with using the standard diff in gex but want to use a
different diff view on the cli I thought it would be a good idea to
disable external diffing tools in gex with the `--no-ext-diff` flag from
git.

This is obviously pretty hacky but judging from #13 it seems like you
want to transition to [libgit2](https://github.com/rust-lang/git2-rs)
eventually anyway, so I thought this would be appropriate for now.
@Piturnah Piturnah removed the help wanted Extra attention is needed label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Piturnah
0