8000 implemented basic channel history endpoint by jadolg · Pull Request #13 · Pipoline/rocket-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

implemented basic channel history endpoint #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2017
Merged

implemented basic channel history endpoint #13

merged 3 commits into from
Mar 3, 2017

Conversation

jadolg
Copy link
Contributor
@jadolg jadolg commented Feb 24, 2017

No description provided.

@dstegelman
Copy link
Collaborator

Hi, thanks for the contribution. Once it can pass pep8 on travis, we can get it merged.

@jadolg
Copy link
Contributor Author
jadolg commented Feb 28, 2017

Sorry I'm on this really slow internet connection and I'm not able to see the travis log. Can you please paste it here?

@dstegelman
Copy link
Collaborator

Travis Output

―――――――――――――――――――――――――――――――――― PEP8-check ――――――――――――――――――――――――――――――――――
/home/travis/build/dstegelman/rocket-python/rocketchat/api.py:46:47: E251 unexpected spaces around keyword / parameter equals
    def get_room_history(self, room_id, oldest = None,**kwargs):
                                              ^
/home/travis/build/dstegelman/rocket-python/rocketchat/api.py:46:49: E251 unexpected spaces around keyword / parameter equals
    def get_room_history(self, room_id, oldest = None,**kwargs):
                                                ^
/home/travis/build/dstegelman/rocket-python/rocketchat/api.py:46:54: E231 missing whitespace after ','
    def get_room_history(self, room_id, oldest = None,**kwargs):
                                                     ^
/home/travis/build/dstegelman/rocket-python/rocketchat/api.py:60:1: W293 blank line contains whitespace
^
/home/travis/build/dstegelman/rocket-python/rocketchat/api.py:61:5: E303 too many blank lines (2)
    def get_my_info(self, **kwargs):

You can also generate the same by loading and executing the tests locally:

py.test tests rocketchat

@jadolg
Copy link
Contributor Author
jadolg commented Mar 1, 2017

thanks. testing is not working properly on my system :( and my bandwith is very poor.
I'll try to fix it in order to keep my contributions going. I like Rocket.Chat and liked your lib a lot. I started developing a bot for my community chatroom using it.

@dstegelman
Copy link
Collaborator

Looks good.

@dstegelman dstegelman merged commit 25f6a5e into Pipoline:master Mar 3, 2017
@dstegelman
Copy link
Collaborator

Released in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jadolg @dstegelman
0