8000 fix(tikv/raft-engine): limit job on master branche by wuhuizuo · Pull Request #3214 · PingCAP-QE/ci · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(tikv/raft-engine): limit job on master branche #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(tikv/raft-engine): limit job on master branche #3214

merged 1 commit into from
Nov 8, 2024

Conversation

wuhuizuo
Copy link
Collaborator
@wuhuizuo wuhuizuo commented Nov 8, 2024

No description provided.

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and diff, it looks like the changes in this pull request are related to limiting jobs on the master branch for the tikv/raft-engine repository. The presubmits.yaml file is being updated to include a branch specification that limits jobs on the master branch.

One potential problem with this change is that it may limit the ability to test changes on the master branch. It's important to ensure that the appropriate tests are still being run on the master branch to catch any potential issues before they are deployed.

One suggestion to mitigate this potential problem is to create a separate branch specifically for testing changes before they are merged into the master branch. This would allow for more thorough testing while still limiting jobs on the master branch.

Another suggestion is to ensure that the appropriate tests are being run on other branches to catch any potential issues earlier in the development process. This could include running tests on feature branches or other branches that are created before changes are merged into the master branch.

Overall, it's important to balance the need for limiting jobs on the master branch with the need for thorough testing to ensure that changes are working as intended before they are deployed.

@ti-chi-bot ti-chi-bot bot requested a review from LykxSassinator November 8, 2024 04:35
@wuhuizuo
Copy link
Collaborator Author
wuhuizuo commented Nov 8, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 8, 2024
@ti-chi-bot ti-chi-bot added the lgtm label Nov 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9a64816 into main Nov 8, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo-patch-2 branch November 8, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LykxSassinator LykxSassinator Awaiting requested review from LykxSassinator

Assignees
No one assigned
Labels
approved area/jobs/prow lgtm size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuhuizuo @ti-chi-bot
0