8000 feat(lib): use git shallow clone for lib cache by purelind · Pull Request #3207 · PingCAP-QE/ci · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(lib): use git shallow clone for lib cache #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2024
Merged

feat(lib): use git shallow clone for lib cache #3207

merged 2 commits into from
Nov 6, 2024

Conversation

purelind
Copy link
Collaborator
@purelind purelind commented Nov 6, 2024
  • Use git shallow clone for lib cache to optimize the issue of incomplete library downloads caused by network quality.
  • Disable the autorefresh lib for folder pingcap

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo November 6, 2024 03:30
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request aims to optimize the library cache by using git shallow clone and disabling the autorefresh lib for folder pingcap. The changes are limited to adding the extensions block with cloneOptions in the aa_folder.groovy files for each folder.

There are no apparent potential problems with this pull request. However, it is recommended to test the changes in a staging environment before merging into the production branch.

As for the fixing suggestion, it is good practice to add comments to the code explaining what the changes do and why they are necessary. This helps other developers understand the changes and makes the codebase more maintainable.

@ti-chi-bot ti-chi-bot bot added the size/M label Nov 6, 2024
wuhuizuo
wuhuizuo reviewed Nov 6, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of the key changes:

  • The pull request introduces the use of git shallow clone to optimize incomplete library downloads due to network quality issues.
  • The pull request also disables the autorefresh lib for the folder pingcap.

Potential problems:

  • The timeout option in the cloneOptions extension is set to 5 seconds, which might be too short for some cases. It might need to be increased depending on the network quality and size of the repository.
  • The refreshTimeMinutes option for the cachingConfiguration is set to 0, which disables auto-refreshing of the library cache. This might lead to stale libraries being used in the future.

Fixing suggestions:

  • Increase the timeout option to a more reasonable value, such as 30 seconds or 1 minute.
  • Set a non-zero value for refreshTimeMinutes to enable auto-refreshing of the library cache. This ensures that the latest libraries are always used.

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 03:41:09.734072315 +0000 UTC m=+1012382.573227861: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot merged commit a6f157a into PingCAP-QE:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo approved these changes

Assignees
No one assigned
Labels
approved area/jobs/jenkins-DSL lgtm size/M
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purelind @wuhuizuo
0