8000 update latest-presubmits.yaml to add trigger of infoschema pkg by BornChanger · Pull Request #3103 · PingCAP-QE/ci · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update latest-presubmits.yaml to add trigger of infoschema pkg #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

update latest-presubmits.yaml to add trigger of infoschema pkg #3103

merged 1 commit into from
Sep 4, 2024

Conversation

BornChanger
Copy link
Contributor

No description provided.

@BornChanger
update latest-presubmits.yaml to add trigger of infoschema pkg
8636842 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Sep 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the Pull Request title and diff, the key change is adding the infoschema package to the list of directories that will trigger the pull-br-integration-test job when changes are made.

There do not appear to be any potential problems with this change, as it is a simple addition to an existing regex pattern.

One suggestion for improvement could be to add a brief explanation in the PR description of why this change is being made and what impact it will have on the CI/CD pipeline. This can help future reviewers or contributors understand the context of the change.

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo September 4, 2024 05:59
@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 4, 2024
@PingCAP-QE PingCAP-QE deleted a comment from ti-chi-bot bot Sep 4, 2024
purelind
purelind approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator
@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 06:03:34.995046982 +0000 UTC m=+424339.513099907: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit d4160b3 into PingCAP-QE:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind purelind approved these changes

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees
No one assigned
Labels
approved area/jobs/prow lgtm size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BornChanger @purelind
0