8000 pd: make real cluster test run by HuSharp · Pull Request #3006 · PingCAP-QE/ci · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pd: make real cluster test run #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2024
Merged

pd: make real cluster test run #3006

merged 2 commits into from
Jun 18, 2024

Conversation

HuSharp
Copy link
Contributor
@HuSharp HuSharp commented Jun 18, 2024

No description provided.

@HuSharp
make test run
0969556 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 18, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and the diff, it seems that the changes are related to enabling the pull_integration_realcluster_test in the latest-presubmits.yaml file for the tikv/pd repository. Specifically, the changes are setting always_run to true and removing optional flag.

It is difficult to identify potential problems without any description or context about the changes made in this pull request. However, a potential problem could be that the pull_integration_realcluster_test is not stable yet and setting always_run to true and removing optional flag could lead to frequent failures or delays in the CI/CD pipeline.

As a fixing suggestion, the pull request author could provide more context and information about 8000 the stability of the pull_integration_realcluster_test and if there are any known issues. Additionally, they could consider keeping the optional flag until the test is stable and consistently passing.

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo June 18, 2024 07:55
@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 18, 2024
@HuSharp
Copy link
Contributor Author
HuSharp commented Jun 18, 2024

test is: https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Fpd%2Fpull_integration_realcluster_test/activity/

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 18, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
make test run
a7220da 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 18, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and the diff, it seems that the changes are related to the CI/CD pipeline for the Tikv project's PD component. Specifically, the changes are making the real cluster test run by setting always_run to true and optional to true.

There are no potential problems with the changes in the pull request, but there is a missing description which makes it difficult to determine what the changes are intended to do.

As a fixing suggestion, the pull request should include a detailed description of the changes made and why they are necessary. This will help future reviewers and contributors to better understand the purpose of the changes.

purelind
purelind approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator
@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-18 08:08:56.212760176 +0000 UTC m=+102262.698249008: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit cef16d2 into PingCAP-QE:main Jun 18, 2024
2 checks passed
@HuSharp HuSharp deleted the make_test_run branch June 18, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind purelind approved these changes

@okJiang okJiang okJiang approved these changes

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees
No one assigned
Labels
approved area/jobs/prow lgtm size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @purelind @okJiang
0