8000 chore: ignore file changed when collect log file by purelind · Pull Request #2988 · PingCAP-QE/ci · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: ignore file changed when collect log file #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

chore: ignore file changed when collect log file #2988

merged 1 commit into from
Jun 11, 2024

Conversation

purelind
Copy link
Collaborator

ignore file changed when collect log file

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo June 11, 2024 03:44
@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 11, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the change is related to ignoring file changes while collecting log files. Looking at the diff, the change involves adding the --warning=no-file-changed flag to the tar command in two different files - pull_br_integration_test.groovy and pull_lightning_integration_test.groovy. This change should prevent the tar command from returning an error when there are no files to archive.

There doesn't seem to be any potential problems with this change. It's a simple change that shouldn't have any negative impact on the existing codebase.

However, it would be good to confirm if there were any issues related to the error returned by the tar command before making this change. Also, it would be beneficial to add some comments in the code explaining why this change was made.

As for fixing suggestions, I would suggest adding a comment in the code explaining why this change was made and how it resolves the issue. Additionally, the pull request description could be more detailed, explaining the problem that was encountered and how this change resolves it.

@purelind
Copy link
Collaborator Author

/hold

@purelind
Copy link
Collaborator Author

test on https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/848/pipeline

@purelind
Copy link
Collaborator Author

/unhold

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 50515ea into PingCAP-QE:main Jun 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees
No one assigned
Labels
approved area/jenkins-pipelines lgtm size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@purelind
0