8000 Update README.md by wuhuizuo · Pull Request #2977 · PingCAP-QE/ci · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update README.md #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2024
Merged

Update README.md #2977

merged 1 commit into from
May 24, 2024

Conversation

wuhuizuo
Copy link
Collaborator

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from purelind May 24, 2024 13:51
@ti-chi-bot ti-chi-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wuhuizuo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
ti-chi-bot bot commented May 24, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the GitHub pull request description and diff, it seems that the only change made is removing the "(in development)" text from the do.pingcap.net line.

There are no potential problems or issues identified in this pull request. However, it would be better if the pull request description explains the reason for the change. Additionally, it's good to follow the standard change management process, such as creating a new branch for this change.

As for fixing suggestions, there's no need for any changes. The pull request can be approved as is.

@ti-chi-bot ti-chi-bot bot added the size/XS label May 24, 2024
@wuhuizuo wuhuizuo merged commit fcbe157 into main May 24, 2024
@wuhuizuo wuhuizuo deleted the wuhuizuo-patch-1 branch May 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind Awaiting requested review from purelind

Assignees
No one assigned
Labels
size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wuhuizuo
0