code review WIP #120
Merged
code review WIP #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f174a1 to
6f0ac48
Compare
blefaudeux
commented
May 26, 2025
|
|
||
| // If we have enough tasks, we'll wait for the older one to finish | ||
| if tasks.len() >= max_tasks && consume_oldest_task(&mut tasks).await.is_ok() { | ||
| if tasks.len() >= max_tasks && tasks.join_next().await.unwrap().is_ok() { |
There was a problem hiding this comment.
this is actually better I believe @photoroman, because tasks have uneven duration and waiting for the first one which is done will be faster (on average) than waiting for the older one.
Moving all the workers to this, also removes this dedicated function shared across the files, which was not very clean, I agree
blefaudeux
added a commit
that referenced
this pull request
Jun 2, 2025
* Better error messages on http path - async tarball pull, but behavior is clunky - general arch could be simpler and using tokio more - handling jpg/png/jpeg/cls/txt/json types - some shuffling handling missing unit tests, and better behavior, doing pauses at the moment better documentation big rewrite, nicer and smaller code I believe (#117) Co-authored-by: Benjamin Lefaudeux <ben@photoroom.com> Async tarball pull and dispatch Random_sampling in the config, at least for now. Thanks for the review Roman ! * Code review (#120) Some missing items (would be good to propagate the archive name for instance), but most fixes should be there * second round, hoopefully good to go. Perf could probably be improved, competing sample pull * handling multi image samples (#121) bugfixing the previous PR, ideally we should unit test more * final update round * second review, not perfect but feels like we can land this and carry on --------- Co-authored-by: Benjamin Lefaudeux <ben@photoroom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied
2EA3
while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storing ongoing work / following up to code review