Update install command for Romi #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
approved these changes
Jan 28, 2025
crschardt
added a commit
to PhotonVision/photon-image-modifier
that referenced
this pull request
Feb 10, 2025
This PR fixes several problems with the `install.sh` script: 1. The script relied on the GitHub rest API to get a list of releases. The return from the API is paginated and only returns 30 items by default. The script now has an optional `count` argument for the `-l` option that allows the user to specify how many releases should be returned. 2. More significantly, the script was using the returned list of releases to determine if a release is available. Since the list was truncated to 30 items, older releases such as the 2023.4.2 version were not seen as available. The script now checks directly with the REST API to determine if a release is available, so the pagination is no longer an issue. 3. Parsing of options with optional arguments was not being done correctly when the short version of the option was used. This is now working correctly. 4. Added a "Test" option that skips all commands that directly make changes to the system. This makes it easier to debug the script without risking making unwanted changes. 5. The script used a pretty restrictive filter for which releases to list and it wouldn't allow users to install "Dev" or "rc" releases. The filter is now much less restrictive. 6. The script now installs the correct jammy repository for Ubuntu 24.04 on x86 systems. NOTE: Raspberry Pi images include `libcamera-dev/stable 0.4.0+rpt20250127-3`. They will only work for PhotonVision jars that include libcameraDriverVersion = v2025.0.4. Documentation update: PhotonVision/photonvision#1746
samdev-7
pushed a commit
to Earl-Of-March-FRC/photonvision
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending PhotonVision/photon-image-modifier#49