8000 Add custom models by samfreund · Pull Request #1687 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add custom models #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jan 8, 2025
Merged

Add custom models #1687

merged 46 commits into from
Jan 8, 2025

Conversation

samfreund
Copy link
Member
@samfreund samfreund commented Jan 7, 2025 •
edited
Loading

This allows for uploading of custom object detection models via the GUI.
image
image

Note #1685 ought to be merged prior to this one, as it contains the same edits.

samfreund added 16 commits January 6, 2025 10:23
@samfreund samfreund requested review from a team as code owners January 7, 2025 20:16
@samfreund
Copy link
Member Author

Someone should test that the files upload properly on a PI, I haven't tested it on that platform as I don't have one readily available.

@mcm001
Copy link
Contributor
mcm001 commented Jan 7, 2025

Do you think this would make sense as its own card on the settings page instead of piled in with all the other buttons?

@samfreund
Copy link
Member Author

Do you think this would make sense as its own card on the settings page instead of piled in with all the other buttons?

I think that would also work. My reasoning was that these were files that would go on the device, so I put it in there. I can make it a separate card tho, that's not much work.

@samfreund
Copy link
Member Author

fixes #1354

@samfreund
Copy link
Member Author

@mcm001 this should be good to go

mcm001
mcm001 reviewed Jan 8, 2025
View reviewed changes
@gerth2
Copy link
Contributor
gerth2 commented Jan 8, 2025

image

Quick test on pi3, looks like the upload card is visible and "works" in the context it accepts files.

image

The front-end camera interface uses this logic to disallow selecting object detection when there's no backend for it available, is it possible to use the same mechanism on the settings page to hide the upload card on platforms where it can't be run?

@samfreund
Copy link
Member Author

This check failed because of dependencies it looks like. Do we think it could be related to #1690?

@spacey-sooty
Copy link
Member

This check failed because of dependencies it looks like. Do we think it could be related to #1690?

Nah CI is just a bit silly sometimes

gerth2
gerth2 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor
@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheeeeee

@mcm001 mcm001 merged commit 27684ee into PhotonVision:main Jan 8, 2025
34 checks passed
mcm001 pushed a commit to mcm001/photonvision that referenced this pull request Feb 18, 2025
@samfreund @mcm001
Add custom models (PhotonVision#1687)
edc4464
@mcm001 mcm001 mentioned this pull request Mar 16, 2025
Closed
@mcm001 mcm001 mentioned this pull request Mar 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 left review comments

@spacey-sooty spacey-sooty spacey-sooty left review comments

@gerth2 gerth2 gerth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samfreund @mcm001 @gerth2 @spacey-sooty
0