8000 Remove camera index in ui by Juniormunk · Pull Request #1677 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove camera index in ui #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 3, 2025
Merged

Remove camera index in ui #1677

merged 15 commits into from
Jan 3, 2025

Conversation

Juniormunk
Copy link
Contributor
@Juniormunk Juniormunk commented Jan 3, 2025 •
edited
Loading

With the new camera matching, this is SUPER BAD! Convert to using camera uuid.

@Juniormunk Juniormunk requested a review from a team as a code owner January 3, 2025 02:53
@mcm001
Copy link
Contributor
mcm001 commented Jan 3, 2025

Oh yeah. What happens now if I delete camera A while I had it selected? Does the selected camera uuid change to a valid one?

mcm001
mcm001 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor
@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

despite touching a buncha scary code, seems to work. ship

@mcm001 mcm001 merged commit ab844a7 into PhotonVision:main Jan 3, 2025
34 checks passed
mcm001 added a commit to mcm001/photonvision that referenced this pull request Feb 18, 2025
@Juniormunk @mcm001
Remove camera index in ui (PhotonVision#1677)
cd0cc1e 
With the new camera matching, this is SUPER BAD! Convert to using camera
uuid.

---------

Co-authored-by: Matt <matthew.morley.ca@gmail.com>
@mcm001 mcm001 mentioned this pull request Mar 16, 2025
Closed
@mcm001 mcm001 mentioned this pull request Mar 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juniormunk @mcm001
0