10000 PhotonPoseEstimator: Stop manually iterating targets by auscompgeek · Pull Request #796 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PhotonPoseEstimator: Stop manually iterating targets #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2023
Merged

PhotonPoseEstimator: Stop manually iterating targets #796

merged 1 commit into from
Feb 11, 2023

Conversation

auscompgeek
Copy link
Contributor
@auscompgeek auscompgeek commented Feb 11, 2023 •
edited
Loading

The map_value_type member type alias was incorrect as it wasn't used anywhere, except for size_type which was incorrectly used only to index a std::span.

Instead of using a C-style for loop to loop over the span of targets, either use a range-for loop (where appropriate) or use iterators.

Also avoid copying in these loops, being consistent with ClosestToCameraHeightStrategy.

@auscompgeek auscompgeek requested a review from a team as a code owner February 11, 2023 12:14
@mcm001 mcm001 merged commit 3edc875 into PhotonVision:master Feb 11, 2023
@auscompgeek auscompgeek deleted the pose-est-yeet-size_type branch February 11, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auscompgeek @mcm001
0