Create C++ Apriltag example #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d62ea86 to
72c04b3
Compare
|
I can't leave a comment but why did the libphotoncam.so change? WPILib version update? |
gerth2
previously approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Looks good with two major caveats:
- I'm bad at c++
- not run on a robot.
Plus a few nits about things that might be better to be ignored, at least for example purposes.
But, in terms of communicating the key concepts, it works.
Sim support soon hopefully :). But likely not till after the season.
| @@ -0,0 +1,102 @@ | |||
| { | |||
There was a problem hiding this comment.
I vote no, so I can set up WASD bindings for driving around
Update .gitignore
|
WPILib version update is coz we forgot to bump gradlerio |
|
Solid |
gerth2
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just copied ramsete from wpilib
Start PhotonCameraWrapper
bump wpilib everywhere