8000 Cache pose calculations in PhotonPoseEstimator by KangarooKoala · Pull Request #788 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cache pose calculations in PhotonPoseEstimator #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 14, 2023
Merged

Cache pose calculations in PhotonPoseEstimator #788

merged 18 commits into from
Feb 14, 2023

Conversation

KangarooKoala
Copy link
Contributor

No description provided.

@KangarooKoala KangarooKoala requested a review from a team as a code owner February 4, 2023 18:27
@KangarooKoala KangarooKoala mentioned this pull request Feb 4, 2023
Closed
@KangarooKoala
Copy link
Contributor Author

I'm not sure about the C++ implementation, also I could make invalidatePoseCache()/InvalidatePoseCache() public, but I don't know if we expect users to need to do that.

mcm001
mcm001 reviewed Feb 4, 2023
View reviewed changes
@KangarooKoala
Copy link
Contributor Author

Also probably don't run the workflow yet, some tests fail locally.

mcm001
mcm001 reviewed Feb 5, 2023
View reviewed changes
@KangarooKoala
Copy link
Contributor Author

Thanks for the working more on this! Also I'm not sure why I misread #779 as reusing old values, but I agree that the original intent makes more sense.

@mcm001 mcm001 merged commit 545e016 into PhotonVision:master Feb 14, 2023
@KangarooKoala KangarooKoala deleted the pose-estimator-caching branch February 14, 2023 02:55
@mdurrani808 mdurrani808 mentioned this pull request Feb 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KangarooKoala @mcm001
0