Add calibration decimate dropdown #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All resolutions 640x480 and higher work better. However 320x240 is now broke -- I couldn't get it to ever show a colored chessboard. This was with decimation 2. Maybe the decimation should default to 1 below a certain resolution? |
|
Yeah, the decimation dropdown works just fine, but the resolution after decimation shouldn't drop down below 320x240. |
|
Users shouldn't want to have targets far away. This leads to suboptimal calibration. |
gerth2
approved these changes
Jan 15, 2023
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
* Increase resized size to 640 * Add calibration decimation dropdown * Update Calibrate3dPipeTest.java * Only allow decimation down to >=320x240 * Update CamerasView.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184 's default resize resolution is too small to detect chessboards very far away, per this cd post. Replaces with a UI-side dropdown which defaults to half. 640 seems like a good middle ground. needs testing on Pi