Switch network management to networkmanager on Linux #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested Pi and Linux laptop; changed IP and hostname on both. Hostname resolution was 50/50 (yay MDNS), but static works great. Laptop and Pi are both reachable at the new static IP right after assignment, and Pi warns when static IP changed like it should. |
|
We can also use this bash command instead of adding the physicalInterface field: |
photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
Show resolved
Hide resolved
Bankst
approved these changes
Jan 18, 2023
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
* Switch network management to networkmanager * Run style * Fix command formatting * Add curst Pi 5 second sleep * Run formatter * Also bring up/down on other linux * Switch to nmcli down/up * Remove sleep in nmcli down/up * Address review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch
2FF5
that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.