8000 Java-side bugfixes for RobotPoseEstimator and PhotonCamera by gerth2 · Pull Request #685 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Java-side bugfixes for RobotPoseEstimator and PhotonCamera #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 2, 2023
Merged

Java-side bugfixes for RobotPoseEstimator and PhotonCamera #685

merged 8 commits into from
Jan 2, 2023

Conversation

gerth2
Copy link
Contributor
@gerth2 gerth2 commented Jan 1, 2023

Closes #684
Closes #683
Closes #681
Closes #680
Closes #678

@gerth2 gerth2 requested a review from a team as a code owner January 1, 2023 18:20
@gerth2 gerth2 force-pushed the photonlib_bugfixes branch from c836eaf to 1d67f74 Compare January 2, 2023 02:30
@mcm001
Copy link
Contributor
mcm001 commented Jan 2, 2023

Does this close #681 ? It doesnt' look like it does

@mcm001
Copy link
Contributor
mcm001 commented Jan 2, 2023

Oh no i see, it does return null in Java now.

@mcm001 mcm001 merged commit aaa886b into PhotonVision:master Jan 2, 2023
MrRedness pushed a commit to MrRedness/photonvision that referenced this pull request Feb 8, 2023
@gerth2 @MrRedness
Java-side bugfixes for RobotPoseEstimator and PhotonCamera (PhotonVis…
7d6a051 
…ion#685)

Closes PhotonVision#684
Closes PhotonVision#683
Closes PhotonVision#681
Closes PhotonVision#680
Closes PhotonVision#678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gerth2 @mcm001
0