Make install script auto-detect arch #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdurrani808
reviewed
Jan 1, 2023
scripts/install.sh
Outdated
| apt-get update | ||
| apt-get install --yes openjdk-11-jdk-headless | ||
| apt update | ||
| apt-get install openjdk-11-jdk-headless; |
There was a problem hiding this comment.
Shouldn't this be jdk 17 now?
There was a problem hiding this comment.
Not required yet, we still target Java 11 language support. And I don't want to change it coz we don't have time to fully test Java 17 right now.
mcm001
added a commit
to mcm001/photonvision
that referenced
this pull request
Jan 1, 2023
Tested on linux x64 and aarch64
0e9ac9b to
ccc1065
Compare
Tested on linux x64 and aarch64
ccc1065 to
132b34b
Compare
gerth2
approved these changes
Jan 2, 2023
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
* Make install script auto-detect arch PhotonVision#679 Tested on linux x64 and aarch64 * Fix arm32 uname string Co-authored-by: Chris Gerth <gerth2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.