8000 Imgsaves to integer by gerth2 · Pull Request #664 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Imgsaves to integer #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 31, 2022
Merged

Imgsaves to integer #664

merged 7 commits into from
Dec 31, 2022

Conversation

gerth2
Copy link
Contributor
@gerth2 gerth2 commented Dec 29, 2022

Update image save technique to use integers, which should improve robustness under NT4

@gerth2 gerth2 requested a review from a team as a code owner December 29, 2022 15:28
@gerth2 gerth2 force-pushed the imgsaves_to_integer branch from 326e971 to 888a894 Compare December 30, 2022 22:14
@gerth2 gerth2 force-pushed the imgsaves_to_integer branch from 24d0947 to e2baa07 Compare December 30, 2022 22:36
mcm001
mcm001 reviewed Dec 31, 2022
View reviewed changes
photon-lib/src/main/native/cpp/photonlib/PhotonCamera.cpp
rootTable->GetBooleanTopic("inputSaveImgCmd").Publish()),
rootTable->GetIntegerTopic("inputSaveImgCmd").Publish()),
inputSaveImgSubscriber(
rootTable->GetIntegerTopic("inputSaveImgCmd").Subscribe(0)),
outputSaveImgEntry(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, for another PR: these are publishers not entries, lol

@mcm001 mcm001 merged commit d0bf64a into PhotonVision:master Dec 31, 2022
@gerth2 gerth2 linked an issue Jan 3, 2023 that may be closed by this pull request
outputSaveImgCmd and inputSaveImgCmd is not reset to false when calling takeOutputSnapshot() or takeInputSnapshot() twice in a row #662
Closed
@gerth2 gerth2 mentioned this pull request Jan 3, 2023
outputSaveImgCmd and inputSaveImgCmd is not reset to false when calling takeOutputSnapshot() or takeInputSnapshot() twice in a row #662
Closed
MrRedness pushed a commit to MrRedness/photonvision that referenced this pull request Feb 8, 2023
@gerth2 @MrRedness
Convert input/output image save to integers (PhotonVision#664)
16a904d 
Changes image saving technique to use integers, not booleans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

outputSaveImgCmd and inputSaveImgCmd is not reset to false when calling takeOutputSnapshot() or takeInputSnapshot() twice in a row
2 participants
@gerth2 @mcm001
0