Linux metrics #641
Merged
Linux metrics #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
approved these changes
Dec 20, 2022
|
Could you push a change that doesn't actually do anything? Just to re-trigger CI |
|
I tried a couple of things, but I don't see any of the CI running in the Github web pages. Let me know if it did not work. |
|
just gunna merge it to get CI to run |
mcm001
added a commit
that referenced
this pull request
Dec 27, 2022
* Revised isRaspian() call to look in multiple spots to check if we're a Pi or not * wpiformat * linefeed fixup * whoops * WIP updating platform * More platform fixups WIP * Condensed metrics classes, but expanded the configuration to default to file, but fall back on hardcoded commands for certain platforms * Migrate unixSupported to isLinux * applied spotless * wpiformat * Linux metrics (#641) * Move generic commands from PiCmds to LinuxCmds; have PiCmds inherit from LinuxCmds * Better names for variables to save the total memory values * Remove "Bionic" from the architecture; that is not actually determined. * Trigger PhotonVision CI * Dummy change to trigger CI * Run format Update index.html Co-authored-by: Mohammad Durrani <46766905+mdurrani808@users.noreply.github.com> Co-authored-by: Paul Rensing <prensing@gmail.com> Co-authored-by: Matt <matthew.morley.ca@gmail.com>
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull reque
8000
st
Feb 8, 2023
* Revised isRaspian() call to look in multiple spots to check if we're a Pi or not * wpiformat * linefeed fixup * whoops * WIP updating platform * More platform fixups WIP * Condensed metrics classes, but expanded the configuration to default to file, but fall back on hardcoded commands for certain platforms * Migrate unixSupported to isLinux * applied spotless * wpiformat * Linux metrics (PhotonVision#641) * Move generic commands from PiCmds to LinuxCmds; have PiCmds inherit from LinuxCmds * Better names for variables to save the total memory values * Remove "Bionic" from the architecture; that is not actually determined. * Trigger PhotonVision CI * Dummy change to trigger CI * Run format Update index.html Co-authored-by: Mohammad Durrani <46766905+mdurrani808@users.noreply.github.com> Co-authored-by: Paul Rensing <prensing@gmail.com> Co-authored-by: Matt <matthew.morley.ca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented metrics for a generic Linux platform. I changed the Pi class to inherit from Linux.
I also removed "bionic" from the AARCH64 entry. That entry matches my Orange Pi 5. Aarch64 is a generic hardware platform. As far as I can tell, there was actually no check that the OS was version "Bionic" (which is now 2+ years old anyway).
I have tested on my Linux laptop and OPi5. I have not had a chance to test on a RPi4.