8000 2023 wpilib update by shueja · Pull Request #607 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2023 wpilib update #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 96 commits into from
Dec 17, 2022
Merged

2023 wpilib update #607

merged 96 commits into from
Dec 17, 2022

Conversation

shueja
Copy link
Contributor
@shueja shueja commented Nov 21, 2022

Unit tests in Photon-Core are throwing UnsatisfiedLinkError, followed by ClassDefNotFoundError. This is caused by CameraServerCvJNI failing to load.

@shueja shueja requested a review from a team as a code owner November 21, 2022 07:26
@shueja
Copy link
Contributor Author
shueja commented Nov 21, 2022

All build environments need to have their versions match here: https://github.com/wpilibsuite/allwpilib/blob/main/.github/workflows/gradle.yml

@mdurrani808 mdurrani808 added this to the 2023 Kickoff milestone Nov 27, 2022
shueja and others added 21 commits November 30, 2022 16:28
@mcm001 mcm001 force-pushed the 2023-wpilib-update branch from db6b0cb to f4b660d Compare November 30, 2022 21:38
@mdurrani808
Copy link
Contributor

mind bumping the opencv in here to whatever the latest 2023 is?

@mcm001 mcm001 force-pushed the 2023-wpilib-update branch from eff1f8a to 4c7e382 Compare December 14, 2022 21:27
gerth2
gerth2 previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor
@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I grow up, I hope I can write software as good as Matt and Jeremiah

@mcm001 mcm001 force-pushed the 2023-wpilib-update branch from c58c6ee to fe596f2 Compare December 16, 2022 15:39
gerth2
gerth2 9E88 previously approved these changes Dec 16, 2022
View reviewed changes
gerth2
gerth2 reviewed Dec 17, 2022
View reviewed changes
Copy link
Contributor
@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good, and deploys nicelly

@mcm001 mcm001 merged commit bb63af6 into PhotonVision:master Dec 17, 2022
@mcm001 mcm001 mentioned this pull request Dec 17, 2022
Closed
MrRedness pushed a commit to MrRedness/photonvision that referenced this pull request Feb 8, 2023
@shueja @MrRedness
Update to wpilib 2023 beta 7 (PhotonVision#607)
93ff70b 
We now need platform specific jars -- reworks actions to support that. Currently only generates 32 bit pi images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 left review comments

@gerth2 gerth2 gerth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023 Kickoff
Development

Successfully merging this pull request may close these issues.
6 participants
@shueja @mdurrani808 @ThadHouse @gerth2 @mcm001 @Ramtech59Sensei
0