Websocket Stream Stats & Robustness Improvements #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increased thread priority for streaming to reduce "stutter/slow" issues - revised client side URL creation order to prevent the possibility of repeat-identical URL's - Improved overlay to only be visible on mouseover, and fully centered in the screen
|
Closes #548 |
mcm001
approved these changes
Dec 1, 2022
mcm001
added a commit
to mcm001/photonvision
that referenced
this pull request
Dec 13, 2022
* Websocket Stream Stats & Robustness Improvements (PhotonVision#605) * wip support for a stats overlay * WIP adding stream stats. But.... eeeh. Corporate. * kbits over mbytes * A ton more tweaks: - Increased thread priority for streaming to reduce "stutter/slow" issues - revised client side URL creation order to prevent the possibility of repeat-identical URL's - Improved overlay to only be visible on mouseover, and fully centered in the screen * wpiformat on js * Add curl (PhotonVision#618) * Add curl * goofy wording Co-authored-by: shueja-personal <32416547+shueja-personal@users.noreply.github.com> * Update heap size for install script (PhotonVision#622) * Logging for NTDataPublisher (PhotonVision#560) * logging for NTDataPublisher * logging name along with index * formatting lol * resolution logging * Removed pipelineManager object from data publisher * aaaaa * bruhh * sim photoncamera WIP. Builds and runs, tests still fail * fixups for broken testcase * Add check for packet of incorrect length (PhotonVision#629) Co-authored-by: Matt <matthew.morley.ca@gmail.com> * Add avahi daemon to install script (PhotonVision#625) * wip test update to beta 5 - still issues * Move native config into root build.gradle * Move back into subproject test, like it should be * Working jni changes for photon-core test * Fix photon core build! huzzah * Yeet * Run formatter * run spotless * Update NTDataPublisher.java * Update build.gradle * Fix photonlib compilation errors * Potentially spam matrix lol * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * fix path separator in main.yml windows fat jar * trying pathsep again * Remove old apriltag libs and fix main * Update Main.java * Add archive platform to shadowjar, update pi image name * Copy paste fixed apirltag classes * Run format * pi dependencies updated, it's running on a pi now! Co-authored-by: Chris Gerth <gerth2@users.noreply.github.com> Co-authored-by: Mohammad Durrani <46766905+mdurrani808@users.noreply.github.com> Co-authored-by: shueja-personal <32416547+shueja-personal@users.noreply.github.com> Co-authored-by: sarah-e-c <71732260+sarah-e-c@users.noreply.github.com> Co-authored-by: Chris Gerth <chrisgerth010592@gmail.com> Co-authored-by: Drew Williams <williams.r.drew@gmail.com>
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
* wip support for a stats overlay * WIP adding stream stats. But.... eeeh. Corporate. * kbits over mbytes * A ton more tweaks: - Increased thread priority for streaming to reduce "stutter/slow" issues - revised clie 6EFE nt side URL creation order to prevent the possibility of repeat-identical URL's - Improved overlay to only be visible on mouseover, and fully centered in the screen * wpiformat on js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small tweaks meant to address some of the issues users have reported with stream robustness.