8000 Fix thinclient address in dev builds and move thinclient by mcm001 · Pull Request #586 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix thinclient address in dev builds and move thinclient #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 13, 2022
Merged

Fix thinclient address in dev builds and move thinclient #586

merged 6 commits into from
Nov 13, 2022

Conversation

mcm001
Copy link
Contributor
@mcm001 mcm001 commented Nov 10, 2022

Update USBFrameProvider.java

Create index.html

Update index.html

Null check stream to prevent spam

8000 @mcm001
Fix thinclient address in dev builds and move thinclient
1e5f6bb 
Update USBFrameProvider.java

Create index.html

Update index.html

Null check stream to prevent spam
@mcm001 mcm001 marked this pull request as ready for review November 10, 2022 21:39
@mcm001 mcm001 requested a review from a team as a code owner November 10, 2022 21:39
@mcm001
Copy link
Contributor Author
mcm001 commented Nov 10, 2022

Closes #581 and #582

@mcm001 mcm001 added this to the 2023 Beta 6 milestone Nov 11, 2022
@gerth2
Copy link
Contributor
gerth2 commented Nov 11, 2022

Looks reasonable enough to me as a stopgap, and importantly covers another npe.

gerth2
gerth2 previously approved these changes Nov 13, 2022
View reviewed changes
@gerth2 gerth2 merged commit dcad7f3 into PhotonVision:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerth2 gerth2 gerth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023 Beta 6
Development

Successfully merging this pull request may close these issues.
2 participants
@mcm001 @gerth2
0