8000 Fixing jcenter issue by sarah-e-c · Pull Request #554 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing jcenter issue #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fixing jcenter issue #554

merged 1 commit into from
Oct 31, 2022

Conversation

sarah-e-c
Copy link
Contributor

Idek what hacktober is :(( but I tested it and it builds now?

@sarah-e-c sarah-e-c requested a review from a team as a code owner October 31, 2022 10:57
@gerth2
Copy link
Contributor
gerth2 commented Oct 31, 2022

Howdy! Thank you so much!

I see a mix of a few changes - all looks directionally correct, various cleanup things. I'll leave a few comments but it's looking darn close. I'll also pull it tonight to try on my own machine (and probably ping a few others on the discord server to do the same, as we were all down with the same build issues yesterday).

gerth2
gerth2 reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor
@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking just for a few quick answers on a few of the questions, and I'll do more checking tonight. Anything out a comment looks good (thank you for the cleanups!)

@gerth2
Copy link
Contributor
gerth2 commented Oct 31, 2022 •
edited
Loading

Purely FYI -

Idek what hacktober is

https://hacktoberfest.com/ - a nifty idea (but somewhat poorly implemented at least in 2020).

The goal of the tag was to encourage folks to work on stuff that was substantial and relevant, rather than just adding ! to a sentence in our readme.

@mcm001 mcm001 merged commit 1412155 into PhotonVision:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerth2 gerth2 gerth2 left review comments

@mdurrani808 mdurrani808 mdurrani808 left review comments

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarah-e-c @gerth2 @mcm001 @mdurrani808
0