Expose camera name #523
Merged
Expose camera name #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If someone else could do the C++ side that would be great |
mcm001
approved these changes
Dec 25, 2022
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
Co-authored-by: Matt <matthew.morley.ca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a getter to
PhotonCamerathat will allow retrieving the hostname of the camera. This could be useful if I'd want to pass the object along and still allow doing things like exposing the port for it (that requires having the hostname) or accessing an entry directly through itsNetworkTableEntryto do something like checking the last update time. I'm aware that the previous was fixed in #504 but I still think this can be useful in the same way I can get the ID of a motor.