Replace MMAL driver with Libcamera #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
commented
Nov 13, 2022
Comment on lines
+79
to
+85
| var settings = pipeline.getSettings(); | ||
| if (settings instanceof AdvancedPipelineSettings) { | ||
| var advanced = (AdvancedPipelineSettings) settings; | ||
| var hsvParams = | ||
| new HSVPipe.HSVParams( | ||
| advanced.hsvHue, advanced.hsvSaturation, advanced.hsvValue, advanced.hueInverted); |
There was a problem hiding this comment.
@Bankst what's a less terrible way to do this?
5a517b5 to
a22202f
Compare
cda1b62 to
00b50e5
Compare
a5a0ac8 to
77c320e
Compare
Update SocketVideoStream.java
gerth2
previously approved these changes
Dec 27, 2022
mcm001
commented
Dec 27, 2022
scripts/generatePiImage.sh
Outdated
| @@ -3,7 +3,7 @@ | |||
| NEW_JAR=$(realpath $(find . -name photonvision\*-linuxarm32.jar)) | |||
| echo "Using jar: " $NEW_JAR | |||
| sudo apt install xz-utils | |||
| curl -sk https://api.github.com/repos/photonvision/photon-pi-gen/releases/tags/v2023.1.0-beta-1 | grep "browser_download_url.*xz" | cut -d : -f 2,3 | tr -d '"' | wget -qi - | |||
| curl -sk https://api.github.com/repos/photonvision/photon-pi-gen/releases/tags/v2023.1.0-beta-2 | grep "browser_download_url.*xz" | cut -d : -f 2,3 | tr -d '"' | wget -qi - | |||
There was a problem hiding this comment.
Actually probably needs us to cut a new release on the pi image gen repo from the aarch64 branch, as well as change the JAR name to linuxarm64
gerth2
approved these changes
Dec 28, 2022
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
Co-authored-by: Chris Gerth <gerth2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LibCameraJNI.java
More memes
Add sleep fixes it