-
Notifications
You must be signed in to change notification settings - Fork 240
AprilTag support #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
AprilTag support #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ci issues
mcm001
previously approved these changes
Sep 28, 2022
Photonlib sim vision system is still broken/only returns zero pose for camera to target translation, tho
Bankst
previously requested changes
Sep 28, 2022
photon-core/src/main/java/org/photonvision/vision/camera/USBCameraSource.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/vision/camera/USBCameraSource.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/vision/pipeline/AprilTagPipeline.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/vision/pipeline/AprilTagPipeline.java
Show resolved
Hide resolved
shueja
commented
Sep 28, 2022
photon-core/src/main/java/org/photonvision/vision/target/TargetModel.java
Show resolved
Hide resolved
mcm001
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.