Make process_samples on SampleMP jit-compatible with Tracer indices #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6211 +/- ##
==========================================
+ Coverage 98.30% 99.60% +1.29%
==========================================
Files 445 445
Lines 43152 42364 -788
==========================================
- Hits 42422 42195 -227
+ Misses 730 169 -561 ☔ View full report in Codecov by Sentry. |
lillian542
commented
Sep 4, 2024
…e into process_samples_jit
albi3ro
reviewed
Sep 4, 2024
lillian542
commented
Sep 5, 2024
astralcai
approved these changes
Sep 5, 2024
|
[sc-60183] |
mudit2812
pushed a commit
that referenced
this pull request
Sep 10, 2024
…6211) **Context:** There is a use case in catalyst (currently a WIP, sampling an observable using `measurements_from_samples` to diagonalize everything) that results in `indices` in the `process_samples` function being an abstract `Tracer`, and then things break that don't need to. **Description of the Change:** Update the jax `take` dispatch in `qml.math` to cast indices to a jax array instead of a vanilla numpy array
mudit2812
pushed a commit
that referenced
this pull request
Sep 12, 2024
…6211) **Context:** There is a use case in catalyst (currently a WIP, sampling an observable using `measurements_from_samples` to diagonalize everything) that results in `indices` in the `process_samples` function being an abstract `Tracer`, and then things break that don't need to. **Description of the Change:** Update the jax `take` dispatch in `qml.math` to cast indices to a jax array instead of a vanilla numpy array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There is a use case in catalyst (currently a WIP, sampling an observable using
measurements_from_samplesto diagonalize everything) that results inindicesin theprocess_samplesfunction being an abstractTracer, and then things break that don't need to.Description of the Change:
Update the jax
takedispatch inqml.mathto cast indices to a jax array instead of a vanilla numpy array