[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default.qubit.torch #6208

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Remove default.qubit.torch #6208

merged 13 commits into from
Sep 9, 2024

Conversation

albi3ro
Copy link
Contributor
@albi3ro albi3ro commented Sep 4, 2024

Removes default.qubit.torch. Follows on from the removal of default.qubit.tf. Each interface device will be its own PR to keep the scope of the changes managable.

[sc-72784]

astralcai
astralcai approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor
@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov Codecov
Copy link
codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (2113051) to head (908591b).
Report is 344 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6208      +/-   ##
==========================================
+ Coverage   99.60%   99.63%   +0.02%     
==========================================
  Files         446      445       -1     
  Lines       42492    42388     -104     
==========================================
- Hits        42326    42232      -94     
+ Misses        166      156      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from remove-default-qubit-tf to master September 6, 2024 14:32
@albi3ro albi3ro requested a review from mudit2812 September 6, 2024 15:34
PietropaoloFrisoni
PietropaoloFrisoni approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor
@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

tests/templates/test_subroutines/test_reflection.py Show resolved Hide resolved
@albi3ro albi3ro enabled auto-merge (squash) September 9, 2024 19:00
@albi3ro albi3ro merged commit 0b8877e into master Sep 9, 2024
37 checks passed
@albi3ro albi3ro deleted the remove-default-qubit-torch branch September 9, 2024 19:34
mudit2812 pushed a commit that referenced this pull request Sep 10, 2024
@albi3ro @mudit2812
Remove default.qubit.torch (#6208)
8bb1d80 
Removes `default.qubit.torch`. Follows on from the removal of
`default.qubit.tf`. Each interface device will be its own PR to keep the
scope of the changes managable.

[sc-72784]
mudit2812 pushed a commit that referenced this pull request Sep 12, 2024
@albi3ro @mudit2812
Remove default.qubit.torch (#6208)
4eb4d88 
Removes `default.qubit.torch`. Follows on from the removal of
`default.qubit.tf`. Each interface device will be its own PR to keep the
scope of the changes managable.

[sc-72784]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietropaoloFrisoni PietropaoloFrisoni PietropaoloFrisoni approved these changes

@astralcai astralcai astralcai approved these changes

@mudit2812 mudit2812 Awaiting requested review from mudit2812

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albi3ro @astralcai @PietropaoloFrisoni