-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings for two_qubit_unitary
#6437
Conversation
Note: This is only for suppressing static check of differentiability. The essential difficulty of this method to be differentiable persists. Further warnings will be included in the same script.
Hello. You may have forgotten to update the changelog!
|
The replacement of the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6437 +/- ##
=======================================
Coverage 99.38% 99.39%
=======================================
Files 450 450
Lines 42619 42624 +5
=======================================
+ Hits 42359 42364 +5
Misses 260 260 ☔ View full report in Codecov by Sentry. |
two_qubit_unitary
Co-authored-by: Christina Lee <christina@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Just a totally optional suggestion
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
Thanks a lot for reviews! I'll mod the changelog and merge |
Note: This is only for suppressing static check of differentiability. The essential difficulty of this method to be differentiable persists. Further warnings will be included in the same script. ### Before submitting Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory! - [x] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [x] Ensure that the test suite passes, by running `make test`. - [ ] Add a new entry to the `doc/releases/changelog-dev.md` file, summarizing the change, and including a link back to the PR. - [x] The PennyLane source code conforms to [PEP8 standards](https://www.python.org/dev/peps/pep-0008/). We check all of our code against [Pylint](https://www.pylint.org/). To lint modified files, simply `pip install pylint`, and then run `pylint pennylane/path/to/file.py`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** `qml.ops.op_math.decompositions.two_qubit_unitary.py` is not differentiable. **Description of the Change:** Will raise warning if users try call this method in differentiable way **Benefits:** Raise caution regarding the non-differentiability of affected program Temporarily help prevent usage of this method in differentiable way until full implementation in the future **Possible Drawbacks:** Not fully fix the affected issue. **Related GitHub Issues:** #6045 **Related Shortcut Stories:** [sc-69959] --------- Co-authored-by: Christina Lee <christina@xanadu.ai> Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
Context:
qml.ops.op_math.decompositions.two_qubit_unitary.py
is not differentiable.Description of the Change:
Will raise warning if users try call this method in differentiable way
Benefits:
Raise caution regarding the non-differentiability of affected program
Temporarily help prevent usage of this method in differentiable way until full implementation in the future
Possible Drawbacks:
Not fully fix the affected issue.
Related GitHub Issues:
#6045
Related Shortcut Stories:
[sc-69959]