Truncate and log unbounded numerics that don't fit into destination type #3069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilidemi
commented
Jun 19, 2025
|
Are ColumnSettings with DestinationName different from SourceName supported? Seeing tests fail when I'm trying those but maybe I'm doing it wrong Edit: not intended to be supported right now |
ilidemi
commented
Jun 23, 2025
serprex
reviewed
Jun 23, 2025
serprex
approved these changes
Jun 23, 2025
serprex
reviewed
Jun 23, 2025
serprex
reviewed
Jun 23, 2025
serprex
reviewed
Jun 24, 2025
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
…#3066) this avoids breaking existing setups build on pgvector types coming through as strings this system can be used in the future to maintain a chronology of breaking changes & not apply new behavior to old mirrors it's meant to be a single dimension, so there isn't the exponential explosion of feature combinations we have with the dynconf system We've previously tried to leverage by having breaking changes only be introduced as optional features, but this hits two problems: old behavior has to be default, & it's a complicated mechanism designed for flexible configuration, rather than a means to gate backwards incompatible changes from existing mirrors this represents a point in PeerDB's life where we have people who just want the thing they tested (+ security fixes, etc) infra for managing this system will be future work, outlined in #3095
iamKunalGupta
reviewed
Jun 25, 2025
8000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it, unified the four places where we were deciding on which type to use at the destination.
Attempted to support truncation from wider to narrower decimals in case the customer creates such columns, but we seem to royally not support diverging schemas for numerics. If anyone in the future has to implement this, hit me up for a bunch of test cases.