Resync fix: update cfg with state before resync calls #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heavycrystal
approved these changes
May 8, 2025
iskakaushik
approved these changes
May 8, 2025
Amogh-Bharadwaj
added a commit
that referenced
this pull request
May 9, 2025
This PR adds a test to check if resync picks up added tables and they are well and truly part of the CDC pipeline. It is a follow-up of #2917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression introduced by #2764 where we update the flow configuration proto in the flows table in drop flow when we trigger resync.
Unfortunately the mirror configuration passed to this operation as input is an outdated configuration which does not have the latest flow updates - sync interval, batch size or table mappings. So none of those get passed on to the new resynced mirror.