8000 Fix SOREUSEPORTS logging multiple times upon startup and shutdown for port listening by R00tB33rMan · Pull Request #1535 · PaperMC/Velocity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix SOREUSEPORTS logging multiple times upon startup and shutdown for port listening #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev/3.0.0
Choose a base branch
from
Open

Fix SOREUSEPORTS logging multiple times upon startup and shutdown for port listening #1535

wants to merge 1 commit into from

Conversation

R00tB33rMan
Copy link
Contributor

Pretty much as the title describes. I'm assuming this is the correct way to handle this. Correct me if I'm wrong!

@electronicboy
Copy link
Member

Conflicted, because this would break if we ever added multiple listeners; part of the reality is that the current behavior is actually technically correct

@Potothingi
Copy link

This may be intentional behavior. The netty worker numbers are different. (Netty epoll Worker #0~9)

[15:49:03] [Netty epoll Worker #0/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #1/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #2/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #3/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #4/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #5/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #6/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #7/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #8/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565
[15:49:03] [Netty epoll Worker #9/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565

@electronicboy
Copy link
Member

it is intentional that it binds on multiple listeners. I can imagine. that for some, the extra logging in this mode is I am somewhat inclined to just call this WAI, I'm not really sure how you'd cleanly distinguish some of this otherwise

@R00tB33rMan
Copy link
Contributor Author

Yeah, I anticipated that it could have been intentional despite it looking a tad weird upon startup/shutdown, and I (too) am not sure how this could otherwise be handled. I'll leave this PR open, assuming I come up with a proposed idea or someone else recommends how this should be handled (or maybe it should remain as is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@R00tB33rMan @electronicboy @Potothingi
0