8000 [Unified Checkpoint] Fix split param loading directly when using ignore_merge_optimizer by DesmonDay · Pull Request #9935 · PaddlePaddle/PaddleNLP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Unified Checkpoint] Fix split param loading directly when using ignore_merge_optimizer #9935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

[Unified Checkpoint] Fix split param loading directly when using ignore_merge_optimizer #9935

merged 3 commits into from
Feb 26, 2025

Conversation

DesmonDay
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

同时开启ignore_merge_optimizer和split_param模式下，直接加载保存下来的checkpoint会报错，此处进行修复。

@paddle-bot Paddle-bot
Copy link
paddle-bot bot commented Feb 24, 2025

Thanks for your contribution!

@codecov Codecov
Copy link
codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.50407% with 115 lines in your changes missing coverage. Please review.

Project coverage is 51.31%. Comparing base (30df8b6) to head (99fb78d).
Report is 343 commits behind head on develop.

Files with missing lines Patch % Lines
...r/unified_checkpoint/sharding_split_param_utils.py 5.83% 113 Missing ⚠️
...p/trainer/unified_checkpoint/unified_checkpoint.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9935      +/-   ##
===========================================
- Coverage    51.34%   51.31%   -0.03%     
===========================================
  Files          745      745              
  Lines       118590   118678      +88     
===========================================
+ Hits         60886    60902      +16     
- Misses       57704    57776      +72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZHUI ZHUI force-pushed the fix_split_param_v2 branch from f578946 to c0c7c78 Compare February 24, 2025 11:30
@ZHUI ZHUI force-pushed the fix_split_param_v2 branch from c0c7c78 to 1e250f4 Compare February 24, 2025 11:53
@ZHUI ZHUI force-pushed the fix_split_param_v2 branch from 52fbbf3 to 99fb78d Compare February 24, 2025 12:15
ZHUI
ZHUI approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator
@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 011ae71 into develop Feb 26, 2025
11 of 14 checks passed
@ZHUI ZHUI deleted the fix_split_param_v2 branch February 26, 2025 08:02
ZHUI pushed a commit that referenced this pull request Feb 27, 2025
@DesmonDay
[Unified Checkpoint] Fix split param loading directly when using igno…
64fe936 
…re_merge_optimizer (#9935)

* fix

* refine code

* update typename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DesmonDay @ZHUI
0