8000 [Embedding] Fix embedding random by DesmonDay · Pull Request #9721 · PaddlePaddle/PaddleNLP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Embedding] Fix embedding random #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

[Embedding] Fix embedding random #9721

merged 1 commit into from
Jan 2, 2025

Conversation

DesmonDay
Copy link
Contributor
@DesmonDay DesmonDay commented Dec 31, 2024 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Description

Trainer所保存的random种子对于数据流不起作用，需要改成独立Random实例。

@codecov Codecov
Copy link
codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.01%. Comparing base (3aa9f4c) to head (b2e32ce).
Report is 268 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/datasets/embedding_dataset.py 11.11% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9721      +/-   ##
===========================================
- Coverage    53.30%   53.01%   -0.29%     
===========================================
  Files          724      718       -6     
  Lines       118271   112451    -5820     
===========================================
- Hits         63039    59615    -3424     
+ Misses       55232    52836    -2396

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ZHUI
ZHUI approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator
@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddlenlp/datasets/embedding_dataset.py Outdated
@@ -50,6 +50,8 @@ class Pair:
class EmbeddingDatasetMixin:
"""EmbeddingDatasetMixin."""

rng = random.Random(10) # random seed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为什么固定seed，还不可以调整

@ZHUI ZHUI merged commit 3a3bb65 into PaddlePaddle:develop Jan 2, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DesmonDay @ZHUI
0