8000 【Hackathon 7th No.43】完善 TokenizerFast 功能支持 part 4 by yinfan98 · Pull Request #9577 · PaddlePaddle/PaddleNLP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

【Hackathon 7th No.43】完善 TokenizerFast 功能支持 part 4 #9577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2024
Merged

【Hackathon 7th No.43】完善 TokenizerFast 功能支持 part 4 #9577

merged 6 commits into from
Dec 9, 2024

Conversation

yinfan98
Copy link
Contributor
@yinfan98 yinfan98 commented Dec 5, 2024

PR types

New features

PR changes

Others

Description

gemma tokenizer fast, 跳过 test_create_token_type_ids 测试因为transformers库里也跳过。该操作符合预期

@paddle-bot Paddle-bot
Copy link
paddle-bot bot commented Dec 5, 2024

Thanks for your contribution!

@codecov Codecov
Copy link
codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.89655% with 50 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (cfcd079) to head (ea57946).
Report is 1 commits behind head on develop.

❗ Current head ea57946 differs from pull request most recent head ebfe259

Please upload reports for the commit ebfe259 to get more accurate results.

Files with missing lines Patch % Lines
paddlenlp/transformers/convert_slow_tokenizer.py 30.23% 30 Missing ⚠️
paddlenlp/transformers/gemma/tokenizer_fast.py 72.22% 20 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9577      +/-   ##
===========================================
- Coverage    53.09%   52.83%   -0.26%     
===========================================
  Files          703      703              
  Lines       110897   110792     -105     
===========================================
- Hits         58876    58536     -340     
- Misses       52021    52256     +235

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DrownFish19
DrownFish19 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator
@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrownFish19 DrownFish19 merged commit 753436a into PaddlePaddle:develop Dec 9, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrownFish19 DrownFish19 DrownFish19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinfan98 @DrownFish19
0