8000 [NPU] Fix sequence parallel lib import by DrownFish19 · Pull Request #8760 · PaddlePaddle/PaddleNLP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[NPU] Fix sequence parallel lib import #8760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

[NPU] Fix sequence parallel lib import #8760

merged 1 commit into from
Jul 15, 2024

Conversation

DrownFish19
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Description

Fix sequence parallel lib import.

  1. When replacing LoRA module for npu device, ColumnSequenceParallelLoRALinear and RowSequenceParallelLoRALinear should inherit from MC2ColumnSeqParallelLinear and MC2RowSeqParallelLinear, respectively.
  2. export FLAGS_NPU_MC2=1 can open MC2ColumnSeqParallelLinear and MC2RowSeqParallelLinear.

@paddle-bot Paddle-bot
Copy link
paddle-bot bot commented Jul 12, 2024

Thanks for your contribution!

@ZHUI ZHUI merged commit be957f0 into PaddlePaddle:develop Jul 15, 2024
11 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_fix_npu_sep_import branch July 15, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrownFish19 @ZHUI
0