Tools & Plugin: Dynamic Visual Studio path detection #18
Conversation
There was a problem hiding this comment.
The code in this PR is great to be merged as is!
I would just kindly request some cosmetic changes to the commits structure / naming:
- Edit the name of the 7-zip commit
From:
Tools: 7-zip package version updated.
To
Tools: Update 7-zip to version 24.05
(notice no dot at the end, I think I need to fix the Commit message format that talks about adding a dot when there is a further paragraph)
- Squash the remaining commits to a single one
Suggested commit name:
Plugin: Detect Visual Studio path dynamically
or
Plugin: Add VisualStudioPathFinder to de-hardcode visual studio paths
Or in general just try to avoid using past tense (Add, Detect, Update instead of Added, Detected, Updated).
If you use a visual tool like https://fork.dev this is super easy to do with the interactive rebase.
InteractiveRebaseSample.mp4
Of course this can be done also with the git command line with the proper sequence of commands if you happen to know them (I don't! 😅)
Instead of constant strings, "tools" and "plugin" modules detect VS path automatically.
|
Thank you for your patience and detailed explanation. I am not a practiced contributor, but I am trying to learn it fast. |
You're actually the first contributor to this project 🎉 🥇! |
Instead of constant strings, "tools" and "plugin" modules detect VS path automatically.