8000 [Upstream] CActiveMasternode::ManageStatus remove unneeded GetBalance check by lyricidal · Pull Request #351 · PRCYCoin/PRCYCoin · GitHub

More Web Proxy on the site http://driver.im/

[Upstream] CActiveMasternode::ManageStatus remove unneeded GetBalance check #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lyricidal merged 1 commit into develop from upstream-mn_ManageStatus-pr1834

Jan 24, 2023

lyricidal commented

Removed a not needed balance check in CActiveMasternode::ManageStatus (the remote masternode doesn't need to have balance), plus added better logging for the notCapableReason.

long talk with zebra about this ☕ , will need further cleanup but this is going for the right track.

from PIVX-Project/PIVX#1834


          CActiveMasternode::ManageStatus remove unneded GetBalance check

707a7b3

lyricidal added the Upstream label

lyricidal requested review from Shenkyy, lopeed, lucablighthl, anprdev, UserR256, Jamesj66 and apophis1329

January 24, 2023 20:37

anprdev approved these changes

View reviewed changes

lyricidal merged commit b81329b into develop

lyricidal deleted the upstream-mn_ManageStatus-pr1834 branch

January 24, 2023 20:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anprdev anprdev approved these changes

Shenkyy Awaiting requested review from Shenkyy

lopeed Awaiting requested review from lopeed

lucablighthl Awaiting requested review from lucablighthl

UserR256 Awaiting requested review from UserR256

Jamesj66 Awaiting requested review from Jamesj66

apophis1329 Awaiting requested review from apophis1329

Labels

0