8000 [Upstream] [GUI] Better start single MN error description. by lyricidal · Pull Request #346 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [GUI] Better start single MN error description. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

[Upstream] [GUI] Better start single MN error description. #346

merged 1 commit into from
Jan 20, 2023

Conversation

lyricidal
Copy link

Built on top of #1719 .

Fixing/Improving a bad error notification string showed in the GUI due the CMasternodeBroadcast::Create calling CWallet::GetMasternodeVinAndKeys and returning to the GUI the same string error output that is being printed to the log (with all of the extra data, including function names, service etc..).

Can be easily tested creating a masternode, then not waiting for the 15 confirmations and trying to start the node via the menu single masternode start (click on the masternode row and then press start). Without the last commit, will popup a bad error notification text.

from PIVX-Project/PIVX#1732

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Jan 20, 2023
@lyricidal lyricidal merged commit ba18e8a into develop Jan 20, 2023
@lyricidal lyricidal deleted the upstream-mn_start-pr1732 branch January 20, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anprdev anprdev anprdev approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@UserR256 UserR256 Awaiting requested review from UserR256

@Jamesj66 Jamesj66 Awaiting requested review from Jamesj66

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @anprdev
0