8000 [Upstream] [Wallet] Masternodes start performance boost by lyricidal · Pull Request #344 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Wallet] Masternodes start performance boost #344

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2023
Merged

[Upstream] [Wallet] Masternodes start performance boost #344

merged 3 commits into from
Jan 19, 2023

Conversation

lyricidal
Copy link

Problem:

Essentially, every time that the controller started a masternode, it was looping over the entire set of transactions and outputs to get the available ones, then looping again for the specific collateral utxo of the masternode that needs to be started. so.. if the wallet had a big number of transactions, the start all had to process an excessive amount of utxo for each masternode being started Making the start all command slow as hell.

Solution:

GetMasternodeVinAndKeys method rewritten to directly find the collateral utxo in the wallet's map, perform the availability validations and return the needed keys. Zero loops.

from PIVX-Project/PIVX#1698

@lyricidal
Refactor: Abstract out the spendable tx check.
0e86b4a
@lyricidal
Move-only: GetMasternodeVinAndKeys moved next to the available coins …
0e93237 
…method call.

Basically to be able to use the internal CheckTXAvailability method.
@lyricidal
wallet: GetMasternodeVinAndKeys logic rewritten.
ed63273 
Performance boost. Method doing only what it supposed to be doing.
@lyricidal lyricidal added enhancement New feature or request Upstream Upstream backports/fixes labels Jan 19, 2023
@lyricidal lyricidal merged commit afc8c82 into develop Jan 19, 2023
@lyricidal lyricidal deleted the upstream-masternodes_start_all_performance_boost-pr1698 branch January 19, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anprdev anprdev anprdev approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@UserR256 UserR256 Awaiting requested review from UserR256

@Jamesj66 Jamesj66 Awaiting requested review from Jamesj66

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
enhancement New feature or request Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @anprdev
0