8000 [Upstream] build: improve sed robustness by not using sed by lyricidal · Pull Request #303 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] build: improve sed robustness by not using sed #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 27, 2022
Merged

[Upstream] build: improve sed robustness by not using sed #303

merged 10 commits into from
Nov 27, 2022

Conversation

lyricidal
Copy link
@lyricidal lyricidal commented Nov 26, 2022 •
edited
Loading

While using sed can be handy to use for a quick-fix, these instances accumulate, and can become unmaintainable. Not only that, but using sed isn't necessarily robust and it can fail silently. Most of our usage is also missing any documentation explaining why something is being done, when it should be updated/removed etc.

Rather than relying on sed going forward, where possible, I've converted our sed usage into patches. These are easier to maintain, contain documentation, and should fail loudly when they don't apply.
The remaining sed usage, (1 in miniupnpc, the rest in qt), are non-trivial to remove, as they are using build-time variables, or some input from the environment.
This also steals 2 related commits out of bitcoin/bitcoin#19716.
Related to bitcoin/bitcoin#16838.

from bitcoin/bitcoin#19761

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Nov 26, 2022
@lyricidal lyricidal force-pushed the upstream-maximum_sed_robustness branch from 7009487 to fdc4220 Compare November 26, 2022 23:30
@lyricidal lyricidal merged commit 3eda9df into develop Nov 27, 2022
@lyricidal lyricidal deleted the upstream-maximum_sed_robustness branch November 27, 2022 00:19
@lyricidal lyricidal mentioned this pull request Nov 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamesj66 Jamesj66 Jamesj66 approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@anprdev anprdev Awaiting requested review from anprdev

@UserR256 UserR256 Awaiting requested review from UserR256

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @Jamesj66
0