8000 [Upstream] [Tests] Add linter for circular dependencies and start fixing them by lyricidal · Pull Request #266 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Tests] Add linter for circular dependencies and start fixing them #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2022
Merged

[Upstream] [Tests] Add linter for circular dependencies and start fixing them #266

merged 3 commits into from
Sep 20, 2022

Conversation

lyricidal
Copy link

Backports from upstream a shell script which uses the the python script circular-dependencies.py (in devtools) and gives a convenient feedback about any dependency introduced and/or removed. This will be run by GA on any PR (as part of lint-all.sh)

Also, start nuking the first easy circular dependencies caused by unneeded header imports.

from PIVX-Project/PIVX#2641

Note: Some are commented out

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Sep 20, 2022
@lyricidal lyricidal merged commit f7e5013 into develop Sep 20, 2022
@lyricidal lyricidal deleted the upstream-circular_deps_pr2641 branch September 20, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamesj66 Jamesj66 Jamesj66 approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@anprdev anprdev Awaiting requested review from anprdev

@UserR256 UserR256 Awaiting requested review from UserR256

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @Jamesj66
0