8000 [Upstream] [P2P] Enforce expected outbound services by lyricidal · Pull Request #171 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [P2P] Enforce expected outbound services #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 20, 2021
Merged

[Upstream] [P2P] Enforce expected outbound services #171

merged 6 commits into from
Dec 20, 2021

Conversation

lyricidal
Copy link

Another one as part of #4

Backport of bitcoin#7749. This is next in line for #1374.

Original description:

At this point, we do not:

  • check that relayed/stored addr messages have the NODE_NETWORK bit set.
  • check that nodes selected for outbound connection have NODE_NETWORK advertized.
  • check that the nServices flag in the "version" message by a node corresponds to what we expected when deciding to connect to it.
  • store the updated nServices flag from the "version" message in addrman.

Fix this.

from PIVX-Project/PIVX#1616

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Dec 20, 2021
@lyricidal lyricidal requested review from lopeed and anprdev December 20, 2021 17:50
@lopeed lopeed merged commit 0a91b84 into develop Dec 20, 2021
@lopeed lopeed deleted the upstream-checkservices branch December 20, 2021 17:52
@lyricidal lyricidal mentioned this pull request Dec 20, 2021
Open
21 tasks
lyricidal pushed a commit that referenced this pull request Jan 2, 2022
@lopeed @lyricidal
Merge pull request #171 from PRCYCoin/upstream-checkservices
e5eac3f 
[Upstream] [P2P] Enforce expected outbound services
lyricidal pushed a commit that referenced this pull request Jan 4, 2022
@lopeed @lyricidal
Merge pull request #171 from PRCYCoin/upstream-checkservices
ecd43dd 
[Upstream] [P2P] Enforce expected outbound services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopeed lopeed lopeed approved these changes

@anprdev anprdev Awaiting requested review from anprdev

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @lopeed
0