8000 [Upstream] [Core][Cleanup] Add IsRegTestNet() function in chainparams by lyricidal · Pull Request #175 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Core][Cleanup] Add IsRegTestNet() function in chainparams #175

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2021
Merged

[Upstream] [Core][Cleanup] Add IsRegTestNet() function in chainparams #175

merged 1 commit into from
Dec 21, 2021

Conversation

lyricidal
Copy link

This removes many explicit checks Params().NetworkID() != CBaseChainParams::REGTEST / Params().NetworkID() == CBaseChainParams::REGTEST making the code more readable.

PIVX-Project/PIVX#1282

Used in an upcoming PR.

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Dec 20, 2021
@lyricidal lyricidal requested review from lopeed and anprdev December 20, 2021 23:41
@lopeed lopeed merged commit b31368d into develop Dec 21, 2021
@lopeed lopeed deleted the upstream-IsRegTest branch December 21, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopeed lopeed lopeed approved these changes

@anprdev anprdev Awaiting requested review from anprdev

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @lopeed
0